From f0903a060f9d49f12d14b6277dabda15cf7f1509 Mon Sep 17 00:00:00 2001 From: Marek Schwarz Date: Tue, 4 Apr 2023 17:18:15 +0200 Subject: [PATCH 1/2] Removed deprecated field ignore_headers_row from aws_dms_endpoint.s3_settings --- internal/service/dms/endpoint.go | 6 ------ website/docs/r/dms_endpoint.html.markdown | 1 - 2 files changed, 7 deletions(-) diff --git a/internal/service/dms/endpoint.go b/internal/service/dms/endpoint.go index e674a1a329b..4c99b4f120f 100644 --- a/internal/service/dms/endpoint.go +++ b/internal/service/dms/endpoint.go @@ -565,12 +565,6 @@ func ResourceEndpoint() *schema.Resource { Optional: true, Default: "", }, - "ignore_headers_row": { - Type: schema.TypeInt, - Optional: true, - ValidateFunc: validation.IntInSlice([]int{0, 1}), - Description: "This setting has no effect, is deprecated, and will be removed in a future version", - }, "ignore_header_rows": { Type: schema.TypeInt, Optional: true, diff --git a/website/docs/r/dms_endpoint.html.markdown b/website/docs/r/dms_endpoint.html.markdown index e7e119e9193..0ec7036e87a 100644 --- a/website/docs/r/dms_endpoint.html.markdown +++ b/website/docs/r/dms_endpoint.html.markdown @@ -179,7 +179,6 @@ The following arguments are optional: * `encryption_mode` - (Optional) Server-side encryption mode that you want to encrypt your .csv or .parquet object files copied to S3. Valid values are `SSE_S3` and `SSE_KMS`. Default is `SSE_S3`. * `external_table_definition` - (Optional) JSON document that describes how AWS DMS should interpret the data. * `ignore_header_rows` - (Optional) When this value is set to `1`, DMS ignores the first row header in a .csv file. Default is `0`. -* `ignore_headers_row` - (Optional) Deprecated. This setting has no effect. Will be removed in a future version. * `include_op_for_full_load` - (Optional) Whether to enable a full load to write INSERT operations to the .csv output files only to indicate how the rows were added to the source database. Default is `false`. * `max_file_size` - (Optional) Maximum size (in KB) of any .csv file to be created while migrating to an S3 target during full load. Valid values are from `1` to `1048576`. Default is `1048576` (1 GB). * `parquet_timestamp_in_millisecond` - (Optional) - Specifies the precision of any TIMESTAMP column values written to an S3 object file in .parquet format. Default is `false`. From 5fe01fd2aa021ede74e825fcdbb0dc8d2a4ce347 Mon Sep 17 00:00:00 2001 From: Marek Schwarz Date: Tue, 4 Apr 2023 17:23:54 +0200 Subject: [PATCH 2/2] Added changelog entry --- .changelog/30452.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .changelog/30452.txt diff --git a/.changelog/30452.txt b/.changelog/30452.txt new file mode 100644 index 00000000000..e475fe4f7c2 --- /dev/null +++ b/.changelog/30452.txt @@ -0,0 +1,3 @@ +```release-note:breaking-change +resource/aws_dms_endpoint: `s3_settings.ignore_headers_row` has been removed +``` \ No newline at end of file