New resource azurerm_app_service_slot_custom_hostname_binding

[haraldatbmw]

This PR introduces a new resource azurerm_app_service_slot_custom_hostname_binding for adding custom hostname bindings for App Service Slots.

Fixes: #11295

[haraldatbmw]

@jackofallops Please proceed your review here.

[jackofallops]

Hi @haraldatbmw - Thanks for the continued work here. I've left a few more comments below.
For info - Testing of this resource will require us to get a few things set up to support it in our test subscription, but I'll get onto that asap to be able to run the tests.

[haraldatbmw]

@jackofallops Any chance to include this into 2.77.0?

[jackofallops]

Hi @haraldatbmw - apologies for the delay on this one, I'm looking into it next. Some changes in Azure Managed Certs have complicated matters, so I need to re-review from the beginning based on the new information to ensure this new resource will work as intended. I appreciate this is less than ideal, but please bear with me, I'm going to do my best to get it into 2.80.

[github-actions]

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[haraldatbmw]

@jackofallops Is there anything I can do to help releasing this PR?

[tombuildsstuff]

hey @haraldatbmw

Thanks for pushing those changes, apologies for the delayed re-review here.

I've taken a look through and left a handful of minor comments inline, if we can fix those up then this should be otherwise good to merge 👍

Thanks!

[jackofallops]

Hi @haraldatbmw - Apologies again for the continued delays here. I hope you don't mind, but I've made the above change the thumbprint and updated the tests to remove the app-service re-use issue, and allow us to run in our normal CI process. These are passing successfully. (I remove the "multiple" test as it didn't appear to provider any additional value over the basic test?)

[haraldatbmw]

@jackofallops Thanks for finalizing this PR.

[stephybun]

Thanks @haraldatbmw and @jackofallops, one minor comment on an error message, it's no biggie though. LGTM 👍🏼

Addressed

stale

[github-actions]

This functionality has been released in v2.91.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[goldenmami]

I have an issue when I use azurerm_app_service_custom_hostname_binding for slots. below my code + error message:
resource "azurerm_app_service_slot_custom_hostname_binding" "custom_domain_bindings2" {
hostname = "XXXXXX.com"
app_service_slot_id = "/subscriptions/xxxxxxxxx/resourceGroups/xxxxxx/providers/Microsoft.Web/sites/xxxxxxxx"
thumbprint = data.azurerm_key_vault_certificate.intra-cert.thumbprint
ssl_state = "SniEnabled"
}

resource "azurerm_app_service_managed_certificate" "custom_domain_bindings2" {
custom_hostname_binding_id = azurerm_app_service_slot_custom_hostname_binding.custom_domain_bindings2.id #doesn't work !!!!

custom_hostname_binding_id = "/subscriptions/xxxxxxxxx/resourceGroups/xxxxxx/providers/Microsoft.Web/sites/xxxxxxxx/hostNameBindings/xxxxxxx.com" #stay infinite time to create the binding

}

can not parse "custom_hostname_binding_id" as App Service Custom Hostname ID: ID contained more segments than required: "/subscriptions/xxxxxxxxx/resourceGroups/xxxxxx/providers/Microsoft.Web/sites/xxxxxxxx/**slots/xxxxxxxxx/**hostNameBindings/xxxxxxxxxxx.com"

when I put custom_hostname_binding_id without /slots/xxxxxxxxx/ #stay infinite time to create the binding

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.