azurerm_lb_nat_pool: Add support for floating_ip_enabled, tcp_reset_enabled, idle_timeout_in_minutes

[sinbai]

TF_ACC=1 go test ./internal/services/loadbalancer/ -v -parallel 11 -test.run=TestAccAzureRMLoadBalancerNatPool_ -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMLoadBalancerNatPool_basic
=== PAUSE TestAccAzureRMLoadBalancerNatPool_basic
=== RUN TestAccAzureRMLoadBalancerNatPool_complete
=== PAUSE TestAccAzureRMLoadBalancerNatPool_complete
=== RUN TestAccAzureRMLoadBalancerNatPool_update
=== PAUSE TestAccAzureRMLoadBalancerNatPool_update
=== RUN TestAccAzureRMLoadBalancerNatPool_requiresImport
=== PAUSE TestAccAzureRMLoadBalancerNatPool_requiresImport
=== RUN TestAccAzureRMLoadBalancerNatPool_disappears
=== PAUSE TestAccAzureRMLoadBalancerNatPool_disappears
=== RUN TestAccAzureRMLoadBalancerNatPool_updateMultiplePools
=== PAUSE TestAccAzureRMLoadBalancerNatPool_updateMultiplePools
=== CONT TestAccAzureRMLoadBalancerNatPool_basic
=== CONT TestAccAzureRMLoadBalancerNatPool_requiresImport
=== CONT TestAccAzureRMLoadBalancerNatPool_update
=== CONT TestAccAzureRMLoadBalancerNatPool_updateMultiplePools
=== CONT TestAccAzureRMLoadBalancerNatPool_complete
=== CONT TestAccAzureRMLoadBalancerNatPool_disappears
--- PASS: TestAccAzureRMLoadBalancerNatPool_complete (234.87s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_basic (303.70s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_requiresImport (308.64s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_disappears (321.32s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_updateMultiplePools (362.72s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_update (386.37s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/loadbalancer 386.711s

[katbyte]

Thanks for the PR @sinbai - overall looks good aside from some comments on schema which i've left inline

[katbyte]

we usually put enabled on the end

Suggested change

	"enable_floating_ip": {
	"floating_ip_enabled": {

[sinbai]

Fixed

[katbyte]

Suggested change

	"enable_tcp_reset": {
	"tcp_reset_enabled": {

[sinbai]

Fixed

[katbyte]

Thanks @sinbai - looks good now aside from CI not passing

[sinbai]

Thanks @sinbai - looks good now aside from CI not passing

Fixed, thank you.

[katbyte]

THanks @sinbai! LGTM 🍰

[github-actions]

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.