Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster expose portal_fqdn #13887

Merged
merged 2 commits into from
Oct 25, 2021
Merged

azurerm_kubernetes_cluster expose portal_fqdn #13887

merged 2 commits into from
Oct 25, 2021

Conversation

heoelri
Copy link
Contributor

@heoelri heoelri commented Oct 25, 2021

This PR implements the exposure of an attribute called portal_fqdn which represents the azurePortalFqdn attribute in Azure Resource Manager. portal_fqdn contains the FQDN of the AKS Azure Portal resources - this attribute is needed in private cluster scenarios to for example add the FQDN to a private DNS zone.

az aks show -n lab-northeurope-aks -g lab-stamp-northeurope-rg --query azurePortalFqdn

"f62280ff5e2e44a90563ac36e82a96d5-priv.portal.hcp.northeurope.azmk8s.io"
resource "azurerm_kubernetes_cluster" "example" {
  name                = "example-aks1"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  dns_prefix          = "exampleaks1"

  private_cluster_enabled = true

  default_node_pool {}
}

output "aks_azure_portal_fqdn" {
  value = azurerm_kubernetes_cluster.example.portal_fqdn
}
aks_azure_portal_fqdn = "4e69ee7a37868257c903357418e4ec8a-priv.portal.hcp.westeurope.azmk8s.io"

@sebader FYI

@heoelri
Copy link
Contributor Author

heoelri commented Oct 25, 2021

@katbyte the GoLang Linting check has timed out - would you mind checking that for me and perhaps re-running it? Not sure if i did something wrong or if it's just a timeout.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heoelri - LGTM 🍣

@katbyte katbyte merged commit 9ad2fee into hashicorp:main Oct 25, 2021
@katbyte katbyte changed the title azurerm_kubernetes_cluster expose azurePortalFqdn azurerm_kubernetes_cluster expose portal_fqdn Oct 25, 2021
katbyte added a commit that referenced this pull request Oct 25, 2021
@heoelri heoelri deleted the feature/aksExposePortalFqdn branch October 26, 2021 06:51
@github-actions
Copy link

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants