Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_application_insights - support internet_ingestion_enabled, internet_query_enabled #14035

Merged
merged 3 commits into from
Nov 5, 2021
Merged

azurerm_application_insights - support internet_ingestion_enabled, internet_query_enabled #14035

merged 3 commits into from
Nov 5, 2021

Conversation

jhisc
Copy link
Contributor

@jhisc jhisc commented Nov 4, 2021

Added support to disable Internet ingestion and query.

I've matched the variable names to the log_analytics_workspace resource:

  • internet_ingestion_enabled - (Optional) Should the Log Analytics Workflow support ingestion over the Public Internet? Defaults to true.

  • internet_query_enabled - (Optional) Should the Log Analytics Workflow support querying over the Public Internet? Defaults to true.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @jhisc. This looks good but could we add a test for these properties as well like in azurerm_log_analytics_workspace?

@stephybun stephybun added this to the v2.85.0 milestone Nov 5, 2021
@github-actions github-actions bot added size/L and removed size/S labels Nov 5, 2021
@jhisc
Copy link
Contributor Author

jhisc commented Nov 5, 2021

Thanks @stephybun - Tests added and passing

@katbyte katbyte changed the title application_insights Internet ingest and query toggles azurerm_application_insights - support internet_ingestion_enabled, internet_query_enabled Nov 5, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhisc - LGTM 💯

@katbyte katbyte merged commit 9f30979 into hashicorp:main Nov 5, 2021
katbyte added a commit that referenced this pull request Nov 5, 2021
@jhisc jhisc deleted the application_insights branch November 9, 2021 18:42
@github-actions
Copy link

This functionality has been released in v2.85.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants