Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_virtual_network_gateway: Enable configuration of an active-active zone redundant gateway with P2S #14124

Merged
merged 2 commits into from
Nov 11, 2021
Merged

azurerm_virtual_network_gateway: Enable configuration of an active-active zone redundant gateway with P2S #14124

merged 2 commits into from
Nov 11, 2021

Conversation

aristosvo
Copy link
Contributor

@aristosvo aristosvo commented Nov 10, 2021 •
edited
Loading

Fixes #14044

Acceptance Tests

TF_ACC=1 go test -v ./internal/services/network -run=TestAccVirtualNetworkGateway_activeActiveZoneRedundantWithP2S -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccVirtualNetworkGateway_activeActiveZoneRedundantWithP2S
=== PAUSE TestAccVirtualNetworkGateway_activeActiveZoneRedundantWithP2S
=== CONT  TestAccVirtualNetworkGateway_activeActiveZoneRedundantWithP2S
--- PASS: TestAccVirtualNetworkGateway_activeActiveZoneRedundantWithP2S (2485.66s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network     2487.232s

@aristosvo aristosvo force-pushed the network/vnet-gw-aap2s branch from dc3cb28 to 8c83d04 Compare November 10, 2021 11:36
@aristosvo aristosvo force-pushed the network/vnet-gw-aap2s branch from 8c83d04 to 55c4b59 Compare November 10, 2021 12:22
@aristosvo aristosvo force-pushed the network/vnet-gw-aap2s branch from 55c4b59 to 9a8b7e3 Compare November 10, 2021 12:31
@aristosvo aristosvo changed the title azurerm_virtual_network_gateway: Enable active-active config with P2S azurerm_virtual_network_gateway: Enable configuration of an active-active zone redundant gateway with P2S Nov 10, 2021
@aristosvo aristosvo mentioned this pull request Nov 10, 2021
Closed
mbfrahry
mbfrahry approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit 62d4cfc into hashicorp:main Nov 11, 2021
mbfrahry added a commit that referenced this pull request Nov 11, 2021
@mbfrahry
Update changelog for #14124
43680fb
@mbfrahry mbfrahry added this to the v2.85.0 milestone Nov 11, 2021
@github-actions
Copy link

This functionality has been released in v2.85.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/virtual-network-gateway size/M
Projects
None yet
Milestone
v2.85.0
Development

Successfully merging this pull request may close these issues.

azurerm_virtual_network_gateway resource expects 3 IP configuration blocks, however only 2 are allowed.
2 participants
@aristosvo @mbfrahry