Support for azurerm_netapp_snapshot_policy

[paulomarquesc]

This pull request implements support for Azure NetApp Files Snapshot Policy resource and related changes to allow it to be applied in a volume, it also contains the documentation.

This feature is a requirement for upcoming backup feature support.

This closes #7965

Acceptance tests output for azurerm_netapp_snapshot_policy:

❯ make acctests SERVICE='netapp' TESTARGS='-run=TestAccNetAppSnapshotPolicy' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -run=TestAccNetAppSnapshotPolicy -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
TestAccNetAppSnapshotPolicy=== RUN   TestAccNetAppSnapshotPolicy_basic
=== PAUSE TestAccNetAppSnapshotPolicy_basic
=== RUN   TestAccNetAppSnapshotPolicy_hourlySchedule
=== PAUSE TestAccNetAppSnapshotPolicy_hourlySchedule
=== RUN   TestAccNetAppSnapshotPolicy_dailySchedule
=== PAUSE TestAccNetAppSnapshotPolicy_dailySchedule
=== RUN   TestAccNetAppSnapshotPolicy_weeklySchedule
=== PAUSE TestAccNetAppSnapshotPolicy_weeklySchedule
=== RUN   TestAccNetAppSnapshotPolicy_monthlySchedule
=== PAUSE TestAccNetAppSnapshotPolicy_monthlySchedule
=== RUN   TestAccNetAppSnapshotPolicy_requiresImport
=== PAUSE TestAccNetAppSnapshotPolicy_requiresImport
=== RUN   TestAccNetAppSnapshotPolicy_updateSnapshotPolicy
=== PAUSE TestAccNetAppSnapshotPolicy_updateSnapshotPolicy
=== CONT  TestAccNetAppSnapshotPolicy_basic
=== CONT  TestAccNetAppSnapshotPolicy_monthlySchedule
=== CONT  TestAccNetAppSnapshotPolicy_dailySchedule
=== CONT  TestAccNetAppSnapshotPolicy_hourlySchedule
=== CONT  TestAccNetAppSnapshotPolicy_requiresImport
=== CONT  TestAccNetAppSnapshotPolicy_weeklySchedule
=== CONT  TestAccNetAppSnapshotPolicy_updateSnapshotPolicy
--- PASS: TestAccNetAppSnapshotPolicy_basic (278.22s)
--- PASS: TestAccNetAppSnapshotPolicy_dailySchedule (288.53s)
--- PASS: TestAccNetAppSnapshotPolicy_weeklySchedule (293.36s)
--- PASS: TestAccNetAppSnapshotPolicy_hourlySchedule (298.16s)
--- PASS: TestAccNetAppSnapshotPolicy_monthlySchedule (298.36s)
--- PASS: TestAccNetAppSnapshotPolicy_requiresImport (311.42s)
--- PASS: TestAccNetAppSnapshotPolicy_updateSnapshotPolicy (354.97s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp        355.020s

Acceptance test output for azurerm_netapp_volume with azurerm_netapp_snapshot_policy:

❯  make acctests SERVICE='netapp' TESTARGS='-run=TestAccNetAppVolume_snapshotPolicy' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -run=TestAccNetAppVolume_snapshotPolicy -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolume_snapshotPolicy
=== PAUSE TestAccNetAppVolume_snapshotPolicy
=== CONT  TestAccNetAppVolume_snapshotPolicy
--- PASS: TestAccNetAppVolume_snapshotPolicy (722.55s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp        722.610s

[paulomarquesc]

Validate CI is complaining that it does not know the exact resource I'm implementing, so it should be ignored, I validated the issue locally using the "Provider development overrides" so it can use the version that supports the new resource:

[katbyte]

Thanks @paulomarquesc - overall looks good but I do have some comments that I've left inline

[paulomarquesc]

@katbyte / @tombuildsstuff , can we move forward with this PR?

incorrect

[katbyte]

Thanks @paulomarquesc - as discussed in slack LGTM now 🏗️

[github-actions]

This functionality has been released in v2.90.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.