azurerm_function_app - address app_settings on create rather than just on update

[jackofallops]

Fixes #10990
Supersedes #14521

[cmendible]

@jackofallops can we add this test:

https://github.com/cmendible/terraform-provider-azurerm/blob/a181c7d10e877c0f906e1737c9be666e2b77ceeb/internal/services/web/function_app_resource_test.go#L276

It's a full check for the behavior described in #10990

[jackofallops]

Hi @cmendible - I don't believe the additional test is necessary. The issue for that particular case was that the settings were not applied during the initial creation of the resource, so that when Terraform got to the Update step that the resource was previously relying on to apply the settings, it was already behind the private link, so inaccessible. The change here applies the user configured app_settings in the initial creation payload, avoiding the scenario you've experienced.

FWIW - This resource is in the process of being superseded by azurerm_linux_function_app and azurerm_windows_function_app, currently in beta. These will be promoted out of beta as part of the 3.0 major release, at which point the older resources will be marked as deprecated (albeit still available).

[cmendible]

Hi @cmendible - I don't believe the additional test is necessary. The issue for that particular case was that the settings were not applied during the initial creation of the resource, so that when Terraform got to the Update step that the resource was previously relying on to apply the settings, it was already behind the private link, so inaccessible. The change here applies the user configured app_settings in the initial creation payload, avoiding the scenario you've experienced.

FWIW - This resource is in the process of being superseded by azurerm_linux_function_app and azurerm_windows_function_app, currently in beta. These will be promoted out of beta as part of the 3.0 major release, at which point the older resources will be marked as deprecated (albeit still available).

Perfect! looking forward for both versions then! 😉

[katbyte]

Thanks @jackofallops - LGTM 🏗️

[github-actions]

This functionality has been released in v2.90.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.