-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support storing audit data in storage account that is behind a firewall and VNet #14656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @koikonom - LGTM aside from a couple comments left inline
website/docs/r/mssql_server_extended_auditing_policy.html.markdown
Outdated
Show resolved
Hide resolved
internal/services/mssql/mssql_database_extended_auditing_policy_resource_test.go
Outdated
Show resolved
Hide resolved
574a91f
to
b3543aa
Compare
State attribute is essentially implied. If you set an audit policy then it's enabled, otherwise it's not.
b3543aa
to
38e3705
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments/thoughts but this otherwise LGTM 👍
internal/services/mssql/mssql_server_extended_auditing_policy_resource.go
Show resolved
Hide resolved
website/docs/r/mssql_server_extended_auditing_policy.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/mssql_server_extended_auditing_policy.html.markdown
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Harvey <[email protected]>
This functionality has been released in v2.92.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Support storing audit data in storage account that is behind a firewall and VNet