Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support storing audit data in storage account that is behind a firewall and VNet #14656

Merged
merged 11 commits into from
Jan 11, 2022

Conversation

koikonom
Copy link
Contributor

Support storing audit data in storage account that is behind a firewall and VNet

@koikonom koikonom added bug service/mssql Microsoft SQL Server labels Dec 17, 2021
@koikonom koikonom requested a review from a team December 17, 2021 15:12
@koikonom koikonom changed the title b/mssql audit auth zd60182 Support storing audit data in storage account that is behind a firewall and VNet Dec 17, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @koikonom - LGTM aside from a couple comments left inline

Kyriakos Oikonomakos added 6 commits December 20, 2021 16:41
State attribute is essentially implied. If you set an audit policy then
it's enabled, otherwise it's not.
@koikonom koikonom force-pushed the b/mssql_audit_auth_zd60182 branch from b3543aa to 38e3705 Compare December 20, 2021 16:41
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments/thoughts but this otherwise LGTM 👍

@koikonom koikonom merged commit 690806c into main Jan 11, 2022
@koikonom koikonom deleted the b/mssql_audit_auth_zd60182 branch January 11, 2022 18:08
@github-actions github-actions bot added this to the v2.92.0 milestone Jan 11, 2022
koikonom pushed a commit that referenced this pull request Jan 11, 2022
@github-actions
Copy link

This functionality has been released in v2.92.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants