Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r\azurerm_azurerm_web_application_firewall_policy fix #12817 by loose file_upload_limit_in_mb to 4000. #14715

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

lonegunmanb
Copy link
Contributor

Fix #12817 by loose file_upload_limit_in_mb to 4000.

Acc test:

=== RUN TestAccWebApplicationFirewallPolicy_basic
=== PAUSE TestAccWebApplicationFirewallPolicy_basic
=== CONT TestAccWebApplicationFirewallPolicy_basic
--- PASS: TestAccWebApplicationFirewallPolicy_basic (285.01s)
=== RUN TestAccWebApplicationFirewallPolicy_complete
=== PAUSE TestAccWebApplicationFirewallPolicy_complete
=== CONT TestAccWebApplicationFirewallPolicy_complete
--- PASS: TestAccWebApplicationFirewallPolicy_complete (298.41s)
=== RUN TestAccWebApplicationFirewallPolicy_update
=== PAUSE TestAccWebApplicationFirewallPolicy_update
=== CONT TestAccWebApplicationFirewallPolicy_update
--- PASS: TestAccWebApplicationFirewallPolicy_update (352.67s)
PASS

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @lonegunmanb

@tombuildsstuff tombuildsstuff added this to the v2.91.0 milestone Dec 23, 2021
@tombuildsstuff tombuildsstuff merged commit 49ef531 into hashicorp:main Dec 23, 2021
tombuildsstuff added a commit that referenced this pull request Dec 23, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This functionality has been released in v2.91.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[azurerm_web_application_firewall_policy] Fix max_request_body_size_in_kb, file_upload_limit_in_mb for CRS 3.2
2 participants