r\azurerm_recovery_services_vault #13178 Support for customer-managed keys (CMK) for azurerm_recovery_services_vault
#14718
Conversation
…mer-managed keys (CMK) for azurerm_recovery_services_vault
| Required: true, | ||
| ValidateFunc: keyvaultValidate.NestedItemIdWithOptionalVersion, | ||
| }, | ||
| "infrastructure_encryption_state": { |
There was a problem hiding this comment.
could we change this to a bool?
| "infrastructure_encryption_state": { | |
| "infrastructure_encryption_enabled": { |
There was a problem hiding this comment.
Roger that @katbyte !
|
Thanks @lonegunmanb - looks like we have a test failure now |
|
Hi @katbyte , sorry for that, I'll fix this issue asap. |
|
Hi @katbyte , I think the acc tests should be ok this time, sorry for the failure. === RUN TestAccRecoveryServicesVault_basic --- PASS: TestAccRecoveryServicesVault_update (716.65s) === CONT TestAccRecoveryServicesVault_requiresImport Process finished with the exit code 0 |
|
This functionality has been released in v2.92.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
r\azurerm_recovery_services_vault#13178 Support for customer-managed keys (CMK) for azurerm_recovery_services_vault.Please note that
encryptioncannot been removed after turned on, andencryption.infrastructure_encryption_statecannot been changed once has been set. Considering user could turn onencryptionon existing recovery vault, and data in recovery vault might be extremely important,ForceNewis not an option so this patch added some runtime checks.Though key from hsm is labeled as "Preview" on portal, I've tested that hsm key also works by creating hsm key via azure cli, but since we are lacking of hsm key resource, no acc test for this scenario.
Acc tests:
=== RUN TestAccRecoveryServicesVault_basic
=== PAUSE TestAccRecoveryServicesVault_basic
=== RUN TestAccRecoveryServicesVault_complete
=== PAUSE TestAccRecoveryServicesVault_complete
=== RUN TestAccRecoveryServicesVault_update
=== PAUSE TestAccRecoveryServicesVault_update
=== RUN TestAccRecoveryServicesVault_requiresImport
=== PAUSE TestAccRecoveryServicesVault_requiresImport
=== RUN TestAccRecoveryServicesVault_basicWithIdentity
=== PAUSE TestAccRecoveryServicesVault_basicWithIdentity
=== RUN TestAccRecoveryServicesVault_encryptionWithKeyVaultKey
=== PAUSE TestAccRecoveryServicesVault_encryptionWithKeyVaultKey
=== RUN TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey
=== PAUSE TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey
=== RUN TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage
=== PAUSE TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage
=== RUN TestAccRecoveryServicesVault_changeInfrastructureEncryptionStateShouldHaveClearlyErrorMessage
=== PAUSE TestAccRecoveryServicesVault_changeInfrastructureEncryptionStateShouldHaveClearlyErrorMessage
=== RUN TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption
=== PAUSE TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption
=== RUN TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey
=== PAUSE TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey
=== CONT TestAccRecoveryServicesVault_basic
=== CONT TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey
=== CONT TestAccRecoveryServicesVault_basicWithIdentity
=== CONT TestAccRecoveryServicesVault_update
=== CONT TestAccRecoveryServicesVault_complete
=== CONT TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption
=== CONT TestAccRecoveryServicesVault_requiresImport
=== CONT TestAccRecoveryServicesVault_encryptionWithKeyVaultKey
--- PASS: TestAccRecoveryServicesVault_complete (225.65s)
=== CONT TestAccRecoveryServicesVault_changeInfrastructureEncryptionStateShouldHaveClearlyErrorMessage
--- PASS: TestAccRecoveryServicesVault_basicWithIdentity (233.41s)
=== CONT TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey
--- PASS: TestAccRecoveryServicesVault_requiresImport (237.54s)
=== CONT TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage
--- PASS: TestAccRecoveryServicesVault_basic (243.88s)
--- PASS: TestAccRecoveryServicesVault_update (446.29s)
--- PASS: TestAccRecoveryServicesVault_encryptionWithKeyVaultKey (537.05s)
--- PASS: TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption (539.03s)
--- PASS: TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey (692.59s)
--- PASS: TestAccRecoveryServicesVault_changeInfrastructureEncryptionStateShouldHaveClearlyErrorMessage (526.44s)
--- PASS: TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage (609.27s)
--- PASS: TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey (742.61s)
PASS
Process finished with the exit code 0