-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource azurerm_data_factory_linked_service_odbc
#14787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @onrylmz! Overall this is looking good. Once the comments have been addressed and the test failure is fixed we can have another look over this 🙂
------- Stdout: -------
=== RUN TestAccDataFactoryLinkedServiceOdbc_basic_auth
=== PAUSE TestAccDataFactoryLinkedServiceOdbc_basic_auth
=== CONT TestAccDataFactoryLinkedServiceOdbc_basic_auth
testcase.go:110: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
(map[string]string) {
}
(map[string]string) (len=4) {
(string) (len=22) "basic_authentication.#": (string) (len=1) "1",
(string) (len=24) "basic_authentication.0.%": (string) (len=1) "2",
(string) (len=31) "basic_authentication.0.password": (string) (len=9) "Ch4ngeM3!",
(string) (len=31) "basic_authentication.0.username": (string) (len=4) "emma"
}
--- FAIL: TestAccDataFactoryLinkedServiceOdbc_basic_auth (174.26s)
FAIL
internal/services/datafactory/data_factory_linked_service_odbc_resource.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_linked_service_odbc_resource.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_linked_service_odbc_resource.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_linked_service_odbc_resource.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_linked_service_odbc_resource.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_linked_service_odbc_resource.go
Outdated
Show resolved
Hide resolved
Thanks for the quick reply @stephybun, hope I did address all the missing parts.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating those changes, LGTM 👍🏼
This functionality has been released in v2.91.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes 14770