Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azurerm_data_factory_linked_service_odbc #14787

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

onrylmz
Copy link

@onrylmz onrylmz commented Jan 4, 2022

Fixes 14770

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @onrylmz! Overall this is looking good. Once the comments have been addressed and the test failure is fixed we can have another look over this 🙂

------- Stdout: -------
=== RUN   TestAccDataFactoryLinkedServiceOdbc_basic_auth
=== PAUSE TestAccDataFactoryLinkedServiceOdbc_basic_auth
=== CONT  TestAccDataFactoryLinkedServiceOdbc_basic_auth
testcase.go:110: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
(map[string]string) {
}
(map[string]string) (len=4) {
(string) (len=22) "basic_authentication.#": (string) (len=1) "1",
(string) (len=24) "basic_authentication.0.%": (string) (len=1) "2",
(string) (len=31) "basic_authentication.0.password": (string) (len=9) "Ch4ngeM3!",
(string) (len=31) "basic_authentication.0.username": (string) (len=4) "emma"
}
--- FAIL: TestAccDataFactoryLinkedServiceOdbc_basic_auth (174.26s)
FAIL

@onrylmz onrylmz marked this pull request as draft January 4, 2022 14:05
@onrylmz
Copy link
Author

onrylmz commented Jan 4, 2022

Thanks for the quick reply @stephybun, hope I did address all the missing parts.

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/datafactory -run=TestAccDataFactoryLinkedServiceODBC_basic_auth -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataFactoryLinkedServiceODBC_basic_auth
=== PAUSE TestAccDataFactoryLinkedServiceODBC_basic_auth
=== CONT  TestAccDataFactoryLinkedServiceODBC_basic_auth
--- PASS: TestAccDataFactoryLinkedServiceODBC_basic_auth (97.02s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/datafactory   98.886s

@onrylmz onrylmz requested a review from stephybun January 4, 2022 16:23
@onrylmz onrylmz marked this pull request as ready for review January 4, 2022 16:24
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating those changes, LGTM 👍🏼

@stephybun stephybun merged commit be6895a into hashicorp:main Jan 5, 2022
@github-actions github-actions bot added this to the v2.91.0 milestone Jan 5, 2022
stephybun added a commit that referenced this pull request Jan 5, 2022
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This functionality has been released in v2.91.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Azure Data Factory ODBC Linked Service
2 participants