Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_storage_management_policy: handle unexpected deletion of the referenced storage account #14799

Merged
merged 4 commits into from
Jan 5, 2022
Merged

azurerm_storage_management_policy: handle unexpected deletion of the referenced storage account #14799

merged 4 commits into from
Jan 5, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jan 5, 2022

Fix #12933

tombuildsstuff
tombuildsstuff approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments but this otherwise LGTM - thanks for this @magodo

internal/services/storage/storage_management_policy_resource.go Outdated Show resolved Hide resolved
internal/services/storage/storage_management_policy_resource.go Outdated Show resolved Hide resolved
@katbyte katbyte merged commit 466a70e into hashicorp:main Jan 5, 2022
@github-actions github-actions bot added this to the v2.91.0 milestone Jan 5, 2022
katbyte added a commit that referenced this pull request Jan 5, 2022
@katbyte
CHANGELOG.md for #14799
869260c
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This functionality has been released in v2.91.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/storage size/XS
Projects
None yet
Milestone
v2.91.0
3 participants
@magodo @tombuildsstuff @katbyte