Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDInsight: Support network property for azurerm_hdinsight_hbase_cluster resource #14825

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Jan 6, 2022

The purpose of this PR:

Fix issue #14777. The network property has been supported in azurerm_hdinsight_spark_cluster, azurerm_hdinsight_interactive_query_cluster and azurerm_hdinsight_hadoop_cluster
in PR. But it is not supported in azurerm_hdinsight_hbase_cluster. So, submitted this PR to support private link to azurerm_hdinsight_hbase_cluster.

Test Results(The failed test cases also failed with the same error before modification):

PASS: TestAccHDInsightHBaseCluster_basic (1730.41s)
PASS: testAccHDInsightHBaseCluster_securityProfile(0.301s)
PASS: TestAccHDInsightHBaseCluster_gen2basic (1410.58s)
PASS: TestAccHDInsightHBaseCluster_privateLink (2202.38s)
PASS: TestAccHDInsightHBaseCluster_sshKeys (1137.08s)
PASS: TestAccHDInsightHBaseCluster_requiresImport (1199.04s)
PASS: TestAccHDInsightHBaseCluster_update (2041.36s)
PASS: TestAccHDInsightHBaseCluster_tls (1135.22s)
PASS: TestAccHDInsightHBaseCluster_monitor (1309.90s)
PASS: TestAccHDInsightHBaseCluster_updateMonitor (1791.17s)
FAIL:TestAccHDInsightHBaseCluster_complete
FAIL:TestAccHDInsightHBaseCluster_virtualNetwork
FAIL:TestAccHDInsightHBaseCluster_hiveMetastore
FAIL:TestAccHDInsightHBaseCluster_allMetastores
FAIL:TestAccHDInsightHBaseCluster_updateMetastore
FAIL:TestAccAzureRMHDInsightHBaseCluster_autoscale

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinbai - LGTM 🔉

@katbyte katbyte merged commit 157b99e into hashicorp:main Jan 6, 2022
@github-actions github-actions bot added this to the v2.91.0 milestone Jan 6, 2022
katbyte added a commit that referenced this pull request Jan 6, 2022
@sinbai sinbai deleted the hdinsight/support_network_property branch January 7, 2022 01:26
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This functionality has been released in v2.91.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants