-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add managed_resources block to purview_account 14814 #14865
Add managed_resources block to purview_account 14814 #14865
Conversation
Signed-off-by: Noel Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Noel-Jones - LGTM 🏗️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @Noel-Jones
Thanks for this PR - taking a look through here since these are all Resource IDs can we add an _id
suffix to each of these fields, so that it's clear these are Resource IDs rather than the names?
Thanks!
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
Thanks for the reviews and suggestion. I have committed the suggestions and retested. All looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Noel-Jones - LGTM take 2 🚀🚀
This functionality has been released in v2.92.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Supports the managed_resource block requested in my enhancement resquest issue #14814
This is my first Terraform change therefore grateful for consideration in respect of any missed steps but hopefully I have covered it all!
With respect to the attribute names, I have kept them in sync with the Rest API - I considered it better to be in sync than to add "_id" to the attributes, however, I will do this if this is considered best practice for resource IDs. The documentation states that they are IDs.
Tested within our infrastructure, plan results in the following output against an existing resource and equivalent for a new resource.
Signed-off-by: Noel Jones [email protected]