Adding identity block to azurerm_logic_app_workflow data source

[heoelri]

This PR adds an identity block to the azurerm_logic_app_workflow data source as requested in issue #14876 (@rikribbers).

resource "azurerm_resource_group" "example" {
  name     = "issue14876"
  location = "North Europe"
}

data "azurerm_client_config" "client" {} 

resource "azurerm_logic_app_workflow" "example" {
  name                = "workflow1"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name

  identity {
      type = "SystemAssigned"
  }
}

data "azurerm_logic_app_workflow" "example" {
  name                = azurerm_logic_app_workflow.example.name
  resource_group_name = azurerm_resource_group.example.name
}

resource "azurerm_role_assignment" "reader" {
  scope                = "/subscriptions/${data.azurerm_client_config.client.subscription_id}"
  role_definition_name = "Reader"
  principal_id         = data.azurerm_logic_app_workflow.example.identity.0.principal_id
}

output "identity_type" {
    value = data.azurerm_logic_app_workflow.example.identity.0.type
}

output "identity_tenant_id" {
    value = data.azurerm_logic_app_workflow.example.identity.0.tenant_id
}

output "identity_principal_id" {
    value = data.azurerm_logic_app_workflow.example.identity.0.principal_id
}

This will close #14876.

[rikribbers]

@heoelri thanks for this PR; Allthough I am not a maintainer I would like to see the merged a.s.a.p

2 remarks:

• make sure the checks are all green
• add a test that verifies the existence of the identity

[heoelri]

The linting test failed due to a timeout. That's not related to the code, but reg. the test you're right. Adding one now.

[heoelri]

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/logic -run=LogicAppWorkflowDataSource_* -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLogicAppWorkflowDataSource_identitySystemAssigned
=== PAUSE TestAccLogicAppWorkflowDataSource_identitySystemAssigned
=== RUN   TestAccLogicAppWorkflowDataSource_basic
=== PAUSE TestAccLogicAppWorkflowDataSource_basic
=== RUN   TestAccLogicAppWorkflowDataSource_tags
=== PAUSE TestAccLogicAppWorkflowDataSource_tags
=== CONT  TestAccLogicAppWorkflowDataSource_identitySystemAssigned
=== CONT  TestAccLogicAppWorkflowDataSource_tags
=== CONT  TestAccLogicAppWorkflowDataSource_basic
--- PASS: TestAccLogicAppWorkflowDataSource_tags (78.99s)
--- PASS: TestAccLogicAppWorkflowDataSource_identitySystemAssigned (81.10s)
--- PASS: TestAccLogicAppWorkflowDataSource_basic (81.24s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/logic 81.265s

[rikribbers]

and now we wait for the maintainers.... but for it's good to go.

[tombuildsstuff]

hey @heoelri

Thanks for this PR - I've taken a look through and left a few minor comments inline but if we can fix those up then this should otherwise be good to merge 👍

Thanks!

[heoelri]

hey @heoelri Heyko Oelrichs FTE

Thanks for this PR - I've taken a look through and left a few minor comments inline but if we can fix those up then this should otherwise be good to merge 👍

Thanks!

Thanks for reviewing and for your comments @tombuildsstuff!

[tombuildsstuff]

LGTM - thanks @heoelri

[rikribbers]

Thanks for providing the PR @heoelri and reviewing @tombuildsstuff !

[github-actions]

This functionality has been released in v2.93.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.