fix typo in azurerm_log_analytics_workspace argument: reservation_capcity_in_gb_per_day to reservation_capacity_in_gb_per_day

[aliscott]

Updates argument name reservation_capcity_in_gb_per_day to reservation_capacity_in_gb_per_day.

[favoretti]

Hi @aliscott, thank you for this PR. Whilst this is unfortunate, there might be cases where people are using this parameter. A such we need to add another one with correct spelling, introduce a deprecation message for the old one and then delete it in later releases (3.0?).

In other cases where typos in arguments were corrected, we basically exclude the possibility to set both and pick the value of the one that's currently set.

[favoretti]

Left a comment in main thread. Arguments needs to be properly deprecated, rather than just renamed. Thanks!

[aliscott]

Thanks @favoretti! That makes a lot of sense. I've updated this based on an example I found here: #13881. Let me know if I'm missing anything else.

[favoretti]

LGTM! Pending maintainers review.

[katbyte]

Thanks for spotting and fixing this @aliscott ! LGTM 🏗️

[github-actions]

This functionality has been released in v2.92.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.