Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adding Windows Server node pool with containerd in azurerm_kubernetes_cluster_node_pool #15137

Closed
sossickd opened this issue Jan 27, 2022 · 4 comments

Comments

@sossickd
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Beginning in Kubernetes version 1.20 and greater, you can specify containerd as the container runtime for Windows Server 2019 node pools. From Kubernetes 1.23, containerd will be the default container runtime for Windows. Docker support will be deprecated in Kubernetes 1.24.

This can be enabled by adding the following parameter --aks-custom-headers WindowsContainerRuntime=containerd when creating a Windows node pool.

az aks nodepool add \
    --resource-group myResourceGroup \
    --cluster-name myAKSCluster \
    --os-type Windows \
    --name npwcd \
    --node-vm-size Standard_D4s_v3 \
    --kubernetes-version 1.20.5 \
    --aks-custom-headers WindowsContainerRuntime=containerd \
    --node-count 1

For more information visit here

This feature will give AKS cluster operators the ability to start testing Windows workloads on a node pool running the containerd runtime ahead of Docker being removed in Kubernetes 1.24.

New or Affected Resource(s)

  • azurerm_kubernetes_cluster_node_pool

Potential Terraform Configuration

resource "azurerm_kubernetes_cluster_node_pool" "windows_node_pool" {
  name                 = "test"
  orchestrator_version = "1.20.13"
  os_type = "Windows"
  windows_container_runtime = "Containerd"

  kubernetes_cluster_id = azurerm_kubernetes_cluster.my_cluster.id
  
  ...
}

There would need to be some validation to ensure os_type is set to Windows and that the Kubernetes version is between 1.20.x and 1.23.x.

If Null flag would be omitted.

References

  • #0000
@mybayern1974
Copy link
Collaborator

@sossickd , thank you for opening this issue. Do you think this issue could be duplicate with issue 6793? If so, would you mind if we close this issue and instead you could subscribe to issue 6793?

@sossickd
Copy link
Author

Thanks for the quick reply @mybayern1974 having read through issue 6793 this would enable this feature. I will close this issue and subscribe.

@sossickd
Copy link
Author

sossickd commented Jan 27, 2022

Anyone who comes across this this issue and subsequently subscribes to issue 6793 this has a closed PR with a status or wontfix

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants