Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for managedNetwork in azurerm_machine_learning_workspace #22546

Closed
1 task done
AdamCoulterOz opened this issue Jul 16, 2023 · 2 comments · Fixed by #24951
Closed
1 task done

Support for managedNetwork in azurerm_machine_learning_workspace #22546

AdamCoulterOz opened this issue Jul 16, 2023 · 2 comments · Fixed by #24951

Comments

@AdamCoulterOz
Copy link
Contributor

AdamCoulterOz commented Jul 16, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

In 2023-06-01-preview of Microsoft.MachineLearningServices/workspaces there is a new feature Workspace managed network isolation (preview). It manages the network isolation, virtual network and private linking under the ML Workspace resource. Can we add this property to the resource?

New or Affected Resource(s)/Data Source(s)

azurerm_machine_learning_workspace

Potential Terraform Configuration

resource "azurerm_machine_learning_workspace" "example" {
  name                    = "example-workspace"
  location                = "azregion"
  resource_group_name     = "myrg"
  application_insights_id = "ai-id"
  key_vault_id            = "kv-id"
  storage_account_id      = "sa-id"

  managed_network {
    isolation_mode = "allow_only_approved_outbound" // or "allow_internet_outbound"
  }

  identity {
    type = "SystemAssigned"
  }
}

References

No response

@cramseyio
Copy link

Hi, I am checking in on this. I noticed that this Managed Network Isolation feature was released as GA in October: https://azure.microsoft.com/en-us/updates/azure-machine-learning-general-availability-for-october/

It appears that it is available in this version of the API
Microsoft.MachineLearningServices/workspaces@2023-10-01

I can see it being used here in azapi_resource: https://learn.microsoft.com/en-us/azure/templates/microsoft.machinelearningservices/workspaces?pivots=deployment-language-terraform

Is this something that would be able to be implemented as part of azurerm_machine_learning_workspace now that it's out of preview?

Thanks!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants