Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_billing_account_cost_management_export, azurerm_resource_group_cost_management_export, azurerm_subscription_cost_management_export adding property file_format #27122

Merged

Conversation

ned1313
Copy link
Contributor

@ned1313 ned1313 commented Aug 21, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Add a file_format argument to the resources:

  • azurerm_billing_account_cost_management_export
  • azurerm_resource_group_cost_management_export
  • azurerm_subscription_cost_management_export

The Azure portal has recently added the option to select either Csv or Parquet for the export format. The current API only allows for Csv, but this change is in anticipation of supporting additional formats.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Testing output for tests in export_resource_group_resource_test.go

(TestAccResourceGroupCostManagementExport_basic|TestAccResourceGroupCostManagementExport_update|TestAccResourceGroupCostManagementExport_requiresImport)$ github.com/hashicorp/terraform-provider-azurerm/internal/services/costmanagement

ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/costmanagement	0.024s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_billing_account_cost_management_export - support for the file_format property [GH-00000]
  • azurerm_resource_group_cost_management_export - support for the file_format property [GH-00000]
  • azurerm_subscription_cost_management_export - support for the file_format property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27097

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@ned1313
Copy link
Contributor Author

ned1313 commented Dec 17, 2024

@stephybun requested changes have been made.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ned1313 LGTM 👍

@stephybun stephybun merged commit c5b2f19 into hashicorp:main Jan 8, 2025
34 checks passed
@github-actions github-actions bot added this to the v4.15.0 milestone Jan 8, 2025
stephybun added a commit that referenced this pull request Jan 9, 2025
jackofallops added a commit that referenced this pull request Jan 10, 2025
* Update CHANGELOG.md for #28233

* Update for #28215

* Update CHANGELOG.md for #28279

* Update CHANGELOG.md #28269

* Update CHANGELOG.md #27876

* Update CHANGELOG.md #28069

* Update CHANGELOG.md for #28312

* Update CHANGELOG.md for #28278

* Update CHANGELOG.md #28311

* Update CHANGELOG.md undo 28311

* Update CHANGELOG.md #27874

* Update CHANGELOG.md

* Update CHANGELOG for #28352

* Update CHANGELOG.md for #28390

* Update CHANGELOG.md for #28398

* Update CHANGELOG.md for #28425

* Update CHANGELOG.md #28427

* Update CHANGELOG.md #28280

* Update CHANGELOG.md for #28319

* Update CHANGELOG.md #24801

* Update for #28360 #28216 #27830 #28404 #27401 #27122 #27931 #28442

* Update for #28379

* Update CHANGELOG.md for #28281

* Update for #28380

* Update for #27375

* Update for #25695

* Update CHANGELOG.md #27985

* Update CHANGELOG.md - update release date manually until can be scripted

* Update CHANGELOG.md revert date change as script available

* pre-release script updates

---------

Co-authored-by: stephybun <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: Wyatt Fry <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: kt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for file_format in azurerm_subscription_cost_management_export
4 participants