-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_billing_account_cost_management_export
, azurerm_resource_group_cost_management_export
, azurerm_subscription_cost_management_export
adding property file_format
#27122
Merged
stephybun
merged 6 commits into
hashicorp:main
from
ned1313:cost-management-export-file-format
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
service/cost-management
size/XS
waiting-response
labels
Aug 21, 2024
stephybun
reviewed
Nov 21, 2024
internal/services/costmanagement/export_resource_group_resource_test.go
Outdated
Show resolved
Hide resolved
…e_test.go Co-authored-by: stephybun <[email protected]>
Co-authored-by: stephybun <[email protected]>
@stephybun requested changes have been made. |
stephybun
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ned1313 LGTM 👍
jackofallops
pushed a commit
that referenced
this pull request
Jan 10, 2025
jackofallops
added a commit
that referenced
this pull request
Jan 10, 2025
* Update CHANGELOG.md for #28233 * Update for #28215 * Update CHANGELOG.md for #28279 * Update CHANGELOG.md #28269 * Update CHANGELOG.md #27876 * Update CHANGELOG.md #28069 * Update CHANGELOG.md for #28312 * Update CHANGELOG.md for #28278 * Update CHANGELOG.md #28311 * Update CHANGELOG.md undo 28311 * Update CHANGELOG.md #27874 * Update CHANGELOG.md * Update CHANGELOG for #28352 * Update CHANGELOG.md for #28390 * Update CHANGELOG.md for #28398 * Update CHANGELOG.md for #28425 * Update CHANGELOG.md #28427 * Update CHANGELOG.md #28280 * Update CHANGELOG.md for #28319 * Update CHANGELOG.md #24801 * Update for #28360 #28216 #27830 #28404 #27401 #27122 #27931 #28442 * Update for #28379 * Update CHANGELOG.md for #28281 * Update for #28380 * Update for #27375 * Update for #25695 * Update CHANGELOG.md #27985 * Update CHANGELOG.md - update release date manually until can be scripted * Update CHANGELOG.md revert date change as script available * pre-release script updates --------- Co-authored-by: stephybun <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: Wyatt Fry <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: kt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
Add a
file_format
argument to the resources:azurerm_billing_account_cost_management_export
azurerm_resource_group_cost_management_export
azurerm_subscription_cost_management_export
The Azure portal has recently added the option to select either
Csv
orParquet
for the export format. The current API only allows forCsv
, but this change is in anticipation of supporting additional formats.PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Testing output for tests in
export_resource_group_resource_test.go
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_billing_account_cost_management_export
- support for thefile_format
property [GH-00000]azurerm_resource_group_cost_management_export
- support for thefile_format
property [GH-00000]azurerm_subscription_cost_management_export
- support for thefile_format
property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #27097
Note
If this PR changes meaningfully during the course of review please update the title and description as required.