azurerm_static_web_app - support repository_url, repository_branch, and repository_token properties

[ned1313]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR adds three new arguments for the azurerm_static_web_app resource and two new attributes for the azurerm_static_web_app data source.

• repository_url - URL for repository hosting static web site source files
• repository_branch - Branch on repository to track for changes
• repository_token - A GitHub token with admin permissions to create Actions and monitor the repository

The repository_token is not returned by the Read function, so the data source does not include that attribute.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

To test the updated resource would require a live GitHub repository, branch, and token. There is no facility to create these within the acceptance testing framework. I have manually tested the changes and can confirm that both the updated resource and data source work properly.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_static_web_app - resource support for the repository_url, repository_branch, and repository_token properties [GH-00000]
• azurerm_static_web_app - data source support for the repository_url and repository_branch properties [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #27392

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks for your patience here @ned1313. I've left a few suggestions in-line, I think we can simplify the changes here by doing the behavioural validation for these properties in the schema. If you could make those changes as well as test this locally again that would be great!

[ned1313]

@stephybun all requested changes have been made.

[stephybun]

Thanks @ned1313, the merge conflict needs to be resolved, but once that's done this should be good to go!

[stephybun]

LGTM 🥞