Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation_xx: call MarkAsGone if resource not found in Read #27797

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Oct 29, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

These 3 resource types missed out the mark as gone in Read operation.

  • azurerm_automation_hybrid_runbook_worker_group
  • azurerm_automation_hybrid_runbook_worker
  • azurerm_automation_python3_package

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92, this looks fine to merge, but I noticed that the file names and the acceptance test names don't match the patterns in the provider, which means that tctest can't discover and trigger the tests.

In addition to the suggested renames made in-line, can you also update the corresponding test file with the updated name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be renamed to automation_hybrid_runbook_worker_resource.go

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This to automation_hybrid_runbook_worker_group_resource.go

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks @wuxu92 LGTM 🦖

@stephybun stephybun merged commit 1b14028 into hashicorp:main Oct 29, 2024
30 checks passed
@github-actions github-actions bot added this to the v4.8.0 milestone Oct 29, 2024
stephybun added a commit that referenced this pull request Oct 29, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants