Support more than 16 access policies

[pratik141]

Key Vault supports up to 1024 access policy entries for a key vault.

References

https://docs.microsoft.com/en-us/azure/key-vault/key-vault-secure-your-key-vault#data-plane-access-control - States the 16 limits does not exist anymore

https://www.terraform.io/docs/providers/azurerm/r/key_vault_access_policy.html - Talks about the 16 Object Limit

(fixes #2837 )

[AntoineGa]

I think you should have a look at #2837

[katbyte]

Hi @pratik141,

Thanks for the PR, could we get a test added with 17 policies to ensure the change works?

[katbyte]

(as well as update the documentation?)

[tombuildsstuff]

hey @pratik141

Thanks for this PR :)

Since we've not heard back from you here and there's some outstanding comments which need to be resolved before we can merge this - rather than leaving this open I'm going to close this PR for the moment. Whilst I'm going to close this PR, I'd like to thank you for this contribution - if you (or somebody else) is able to address the remaining comments (adding a test to verify this behaviour works) then we'll be more than happy to take another look :)

Thanks!

[WodansSon]

After speaking with @tombuildsstuff, I am reopening this PR after confirming with the service team that the change to the RP server has been made, which enables this scenario.

[WodansSon]

@pratik141 this LGTM now

[katbyte]

Thanks for the tests @jeffreyCline, I've left a couple comments inline but it's looking good

[katbyte]

LGTM now aside from one minor comment 👍

[WodansSon]

[ghost]

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!