Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed casing of field "SubnetName" for the virtual kubelet/aci addon in AKS #3484

Merged
merged 1 commit into from
May 22, 2019
Merged

Changed casing of field "SubnetName" for the virtual kubelet/aci addon in AKS #3484

merged 1 commit into from
May 22, 2019

Conversation

jlpedrosa
Copy link
Contributor

This fixes he incorrect casing in REST api for AKS. They'll make it backwards compatible as they replied in Azure/AKS#783

So this enables the ACI module working in AKS through terraform.

@ghost ghost added the size/XS label May 21, 2019
@jlpedrosa jlpedrosa changed the title Changed casing for current api version og SubnetName for the virtual kubelet aci Changed casing of field "SubnetName" for the virtual kubelet/aci addon in AKS May 21, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v1.29.0 milestone May 22, 2019
@tombuildsstuff tombuildsstuff merged commit c3f04e9 into hashicorp:master May 22, 2019
tombuildsstuff added a commit that referenced this pull request May 22, 2019
@ghost
Copy link

ghost commented May 26, 2019

This has been released in version 1.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.29.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 21, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants