Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AKS outboundType #5583

Closed
jluk opened this issue Jan 31, 2020 · 11 comments · Fixed by #6120
Closed

Support for AKS outboundType #5583

jluk opened this issue Jan 31, 2020 · 11 comments · Fixed by #6120

Comments

@jluk
Copy link

jluk commented Jan 31, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AKS is enabling a feature to skip setup of standard load balancers (public IP, backend pools) in favor of the user setup with a custom UDR. The AKS feature is here and releasing early Feb:

Azure/AKS#1384

New or Affected Resource(s)

  • azurerm_kubernetes_cluster

https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/internal/services/containers/resource_arm_kubernetes_cluster.go#L346-L468

@jluk
Copy link
Author

jluk commented Jan 31, 2020

FYI @grayzu / @tombuildsstuff

We're releasing this capability within the next week and half in preview, with GA around the corner. Our public docs will be up next week for deeper detail and I'll share here, but this is an early heads up.

Public doc here: aka.ms/aks/outboundtype

@baboune
Copy link
Contributor

baboune commented Feb 12, 2020

@jluk
Copy link
Author

jluk commented Feb 12, 2020

@tombuildsstuff our public doc explaining this should be out by end of week. we can chat a bit more on this feature to clarify if needed.

@baboune
Copy link
Contributor

baboune commented Feb 14, 2020

OK I made some changes to the provider to fix this issue. Since this requires a change of the go module dependencies, before I make a PR, how to handle all the vendor changes triggered by the new github.com/Azure/azure-sdk-for-go v39.1.0+incompatible packge?

@tombuildsstuff
Copy link
Contributor

@baboune thanks for the PR - for the moment I'd suggest holding off vendoring the updated SDK - we'll look to upgrade to version 39.1 of the Azure SDK once we've finished removing the older resources (which we're working through at the moment, since removing these resources also removes the associated packages from the vendor directory) - I'll comment in #5757 once that's done 👍

@baboune
Copy link
Contributor

baboune commented Feb 24, 2020

We need this urgently. Could the associated PR be moved forward?

@baboune
Copy link
Contributor

baboune commented Mar 12, 2020

I already begged for this 17 days ago, any ETAs when this could be merged? Anything I could to to move this forward?

@wagnst
Copy link
Contributor

wagnst commented Mar 13, 2020

FYI the official documentation for the outbound type is here. Merging this, will help to avoid public IPs on the Load Balancer and make it compliant in many enterprise environments (where they do not like to see PIPs - for whatever reason). I really like to see progress here as well.

@evillgenius75
Copy link

@baboune thanks for the PR - for the moment I'd suggest holding off vendoring the updated SDK - we'll look to upgrade to version 39.1 of the Azure SDK once we've finished removing the older resources (which we're working through at the moment, since removing these resources also removes the associated packages from the vendor directory) - I'll comment in #5757 once that's done 👍

@tombuildsstuff where are we with the upgrade of the Azure SDK to 39.1? This is a serious blocker for many and nowwe are having to resort to CLI builds for Enterprise clusters!

@ghost
Copy link

ghost commented Apr 9, 2020

This has been released in version 2.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.5.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.