-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_api_management
- Add http2 protocol support for API Management
#5593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @NickMetz. This change looks good with just a minor suggestion to better match the api
azurerm/internal/services/apimanagement/resource_arm_api_management.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @NickMetz
Thanks for pushing those changes - I've taken a look through and left some comments inline but this is looking good to me, if we can fix up the remaining ones (and the tests pass) then this should otherwise be good 👍
Thanks!
azurerm/internal/services/apimanagement/resource_arm_api_management.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/apimanagement/resource_arm_api_management.go
Outdated
Show resolved
Hide resolved
…ation, update tests
Hi @tombuildsstuff , @mbfrahry, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
azurerm_api_management
- Add http2 protocol support for API Management
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR will fix issue #3621 and add support to enable http2 protocol for API Management.