Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_activity_log_alert recommendationType property #7300

Closed
tjoyce-admin opened this issue Jun 11, 2020 · 4 comments · Fixed by #7458
Closed

azurerm_monitor_activity_log_alert recommendationType property #7300

tjoyce-admin opened this issue Jun 11, 2020 · 4 comments · Fixed by #7458

Comments

@tjoyce-admin
Copy link

tjoyce-admin commented Jun 11, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In the criteria section of the azurerm_monitor_activity_log_alert resource I am not seeing a place to put the properties.recommendationtype value that is required to build an Advisor alert. Any help with this would be appreciated, if not available can it be added?

Sample of an alert I am trying to create but not sure where to put the properties.recommendationtype within this:

resource "azurerm_monitor_activity_log_alert" "default" {
name = "Public IP Address not associated to a running Azure resource"
resource_group_name = "Test"
scopes = ["/subscriptions/02c25313-bb21-4c58-9abb-6e8b093bblkj"]
description = "The alert comes from cost Advisor. Recommended action is to delete the unused public IP address."

criteria {
operation_name = "Microsoft.Advisor/recommendations/available/action"
category = "Recommendation"
}

action {
action_group_id = "/subscriptions/02c25313-bb21-4c58-9abb-6e8b093bblkj/resourcegroups/test/providers/microsoft.insights/actiongroups/Action Group"
}
}

@magodo
Copy link
Collaborator

magodo commented Jun 23, 2020

Hi @tjoyce-admin Thank you for submitting this!
I checked the azure rest api spec for monitor RP, but didn't find anywhere mentioning a property called recommendationtype. Would you kindly provide a reference/link to that?

@magodo magodo self-assigned this Jun 23, 2020
@tjoyce-admin
Copy link
Author

@magodo Here is the link that works with that property in JSON not sure if that will help: https://docs.microsoft.com/th-th/azure///advisor/advisor-alerts

Here is a link for the Rest API that gives you a response with the Recommendation Type included https://docs.microsoft.com/en-us/rest/api/advisor/recommendationmetadata/get.

Not sure of a REST API that creates the monitor for this type. :) I was hoping there is a way to do this but if it is not possible at least I can let management know.

@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants