Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for readiness checks and disabling TCP connections for Cloud Workstation configurations #16997

Closed
daanheikens opened this issue Jan 15, 2024 · 3 comments

Comments

@daanheikens
Copy link

daanheikens commented Jan 15, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The google_workstations_workstation_config resource is currently missing support for the following API fields:

New or Affected Resource(s)

google_workstations_workstation_config

Potential Terraform Configuration

resource "google_workstations_workstation_config" "default" {
  disable_tcp_connections = true 

  readiness_checks {
    path = "/"
    port = 80
  }
  
  readiness_checks {
    path = "/healthz"
    port = 8080
  }
}

References

https://cloud.google.com/workstations/docs/reference/rest/v1beta/projects.locations.workstationClusters.workstationConfigs#resource:-workstationconfig

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/workstations_workstation_config

b/320650639

@github-actions github-actions bot added forward/review In review; remove label to forward service/workstations labels Jan 15, 2024
@bschaatsbergen
Copy link
Member

Hey @daanheikens, thanks for taking the time to raise this issue. I'll happily pick it up 👍🏼.

@bschaatsbergen
Copy link
Member

bschaatsbergen commented Jan 15, 2024

Note, these will be 2 separate PRs.

  • 1 to address the disable_tcp_connections field
  • Another one to introduce the readiness checks

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants