-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "field_manager" attribute #1831
Conversation
…tions, kubernetes_config_map_v1_data
243c8fe
to
209b0a5
Compare
cc @BBBmau as you will probably want to add this attribute to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I'll be sure to add the field to kubernetes_env
resource. Looks a lot cleaner with its own field_manager attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and simple! Only one observation about handling empty string value.
Hi guys, pretty awesome to have the issue fixed. May I know the target due date of the next release? |
Same here, any indication on when to expect this in registry ? It's a significant blocker for us so would be greatly appreciated. |
It's now available in the 2.15.0 release! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds a "field_manager" attribute to the kubernetes_labels, kubernetes_annotations, and kubernetes_config_map_v1_data resources to allow configuring of the field manager name from the currently hard coded default of
Terraform
.This will allow users to specify the manager name if they wish to have multiple Terraform resources that manage different fields of the same Kubernetes resource.
Fixes #1690
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note