Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preemption_policy attribute #1846

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Preemption_policy attribute #1846

merged 4 commits into from
Oct 3, 2022

Conversation

sheneska
Copy link
Contributor

@sheneska sheneska commented Sep 28, 2022

Description

This PR adds the preemption_policy attribute to kubernetes_priority_class resource

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Fixes #1299

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Copy link
Collaborator

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @sheneska! You'll need to:

  • Update the markdown documentation page to add this attribute
  • Add a changelog entry for this change. You can do this by running make changelog-entry at the top level of the repo. You might need to install go-changelog with this command:
go install github.com/hashicorp/go-changelog/cmd/changelog-entry@latest

@jrhouston jrhouston removed their assignment Sep 28, 2022
@sheneska sheneska merged commit a3c86af into main Oct 3, 2022
@sheneska sheneska deleted the preemption-policy branch October 3, 2022 17:51
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support non-preempting priority classes
2 participants