Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing topologySpreadConstraints #2429

Merged
merged 5 commits into from
Feb 27, 2024
Merged

feat: Add missing topologySpreadConstraints #2429

merged 5 commits into from
Feb 27, 2024

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Feb 20, 2024

Description

  • nodeAffinityPolicy
  • nodeTaintsPolicy
  • matchLabelKeys
  • minDomains

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

➜ KUBE_CONFIG_PATH=~/.kube/config KUBE_CTX=kind-acctests make testacc TESTARGS='-run=TestAccKubernetesPodV1_topologySpreadConstraint'
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/Users/alex/git/go/src/github.com/hashicorp/terraform-provider-kubernetes/kubernetes" -v -vet=off -run=TestAccKubernetesPodV1_topologySpreadConstraint -parallel 8 -timeout 3h
=== RUN   TestAccKubernetesPodV1_topologySpreadConstraint
=== PAUSE TestAccKubernetesPodV1_topologySpreadConstraint
=== RUN   TestAccKubernetesPodV1_topologySpreadConstraintMinDomains
=== PAUSE TestAccKubernetesPodV1_topologySpreadConstraintMinDomains
=== CONT  TestAccKubernetesPodV1_topologySpreadConstraint
=== CONT  TestAccKubernetesPodV1_topologySpreadConstraintMinDomains
--- PASS: TestAccKubernetesPodV1_topologySpreadConstraintMinDomains (8.48s)
--- PASS: TestAccKubernetesPodV1_topologySpreadConstraint (8.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-kubernetes/kubernetes	8.994s

Release Note

Release note for CHANGELOG:

`resource/kubernetes_pod_v1`: add missing `topology_spread_constraints`: `node_affinity_policy`, `node_taints_policy`, `match_label_keys`, `min_domains`

References

Closes #2292
Supersedes #2327

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@appilon appilon marked this pull request as ready for review February 22, 2024 18:02
@appilon appilon requested a review from a team as a code owner February 22, 2024 18:02
@appilon appilon merged commit 75da873 into main Feb 27, 2024
26 checks passed
@appilon appilon deleted the appilon/2292 branch February 27, 2024 19:54
lemeurherve referenced this pull request in jenkins-infra/azure Mar 11, 2024
<Actions>
<action
id="bcd9b70d7c1eb1e07eb5ad8a958f18dc1bbd81461ee1a2604adeea46e3148a47">
        <h3>Bump Terraform `kubernetes` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/kubernetes&#34; updated
from &#34;2.26.0&#34; to &#34;2.27.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.27.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v2.27.0&#xA;ENHANCEMENTS:&#xA;&#xA;*
`resource/kubernetes_pod_v1`: add missing `topology_spread_constraints`:
`node_affinity_policy`, `node_taints_policy`, `match_label_keys`,
`min_domains`
[[GH-2429](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2429)]&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/39/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing topologySpreadConstraints options in kubernetes_deployment
2 participants