-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go-tfe to 0.3.13 #72
Conversation
Do we need to change the |
@sudomateo I think if it's |
@justincampbell That makes sense to me. Leaving it required would mean the value would either be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a shame you already tagged a new release for the go-tfe
package, as now we released some code that was waiting for a PR (hashicorp/go-tfe#62) to update/fix the newly added Notification API (which wasn't released yet).
I'm still going to merge that PR, but that means version 0.3.12
and 0.3.13
will now be backwards incompatible for a small bit. I'll tag a new release in a minute, so please use that version instead in this PR.
I prefer API consistency, so please make the |
abb75dc
to
c638bf1
Compare
@svanharmelen Updated to 0.3.13 and marked value as optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #71