Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-tfe to 0.3.13 #72

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Bump go-tfe to 0.3.13 #72

merged 2 commits into from
Mar 25, 2019

Conversation

justincampbell
Copy link
Contributor

Fixes #71

@ghost ghost added the size/XS label Mar 22, 2019
@sudomateo
Copy link
Contributor

Do we need to change the value attribute from required to optional?
https://github.com/terraform-providers/terraform-provider-tfe/blob/master/tfe/resource_tfe_variable.go#L29-L33

@justincampbell
Copy link
Contributor Author

@sudomateo I think if it's Required then an empty string "" would still be allowed. Is there a reason to allow it to be omitted other than for API consistency?

@sudomateo
Copy link
Contributor

@justincampbell That makes sense to me. Leaving it required would mean the value would either be "" or some non-empty string. I don't have any other reason besides API consistency.

Copy link
Contributor

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame you already tagged a new release for the go-tfe package, as now we released some code that was waiting for a PR (hashicorp/go-tfe#62) to update/fix the newly added Notification API (which wasn't released yet).

I'm still going to merge that PR, but that means version 0.3.12 and 0.3.13 will now be backwards incompatible for a small bit. I'll tag a new release in a minute, so please use that version instead in this PR.

@svanharmelen
Copy link
Contributor

svanharmelen commented Mar 25, 2019

I think if it's Required then an empty string "" would still be allowed. Is there a reason to allow it to be omitted other than for API consistency?

I prefer API consistency, so please make the value field optional and default to "" to express it has the exact same behavior as the API (and the docs).

@justincampbell
Copy link
Contributor Author

@svanharmelen Updated to 0.3.13 and marked value as optional

Copy link
Contributor

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justincampbell justincampbell changed the title Bump go-tfe to 0.3.12 Bump go-tfe to 0.3.13 Mar 25, 2019
@justincampbell justincampbell merged commit 296f51a into master Mar 25, 2019
@justincampbell justincampbell deleted the go-tfe-0.3.12 branch March 25, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants