Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(TF-18669) Enable component references #386

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Aug 12, 2024

This change enables the use of component references in the stack schema. This allows users to reference components in the same stack, and have the schema automatically update to reflect the available outputs of the referenced component.

Needs hashicorp/hcl-lang#408

@jpogran jpogran self-assigned this Aug 12, 2024
@jpogran jpogran force-pushed the enable_component_references branch from 9b49d08 to 13ee81c Compare August 12, 2024 21:02
@jpogran jpogran changed the title Enable component references (TF-18667) Enable component references Aug 12, 2024
@jpogran jpogran force-pushed the enable_component_references branch from 13ee81c to cba9a8d Compare August 12, 2024 21:04
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Two comments / questions (I also pushed one commit that already addresses the one comment I had)

schema/stacks/stack_schema_merge.go Outdated Show resolved Hide resolved
schema/stacks/stack_schema_merge.go Outdated Show resolved Hide resolved
@jpogran jpogran marked this pull request as ready for review August 14, 2024 14:49
@jpogran jpogran requested a review from a team as a code owner August 14, 2024 14:49
This change enables the use of component references in the stack schema. This allows users to reference components in the same stack, and have the schema automatically update to reflect the available outputs of the referenced component.

Co-authored-by: Ansgar Mertens <[email protected]>
@jpogran jpogran force-pushed the enable_component_references branch from 3a4707b to 33c354e Compare August 14, 2024 16:10
@ansgarm ansgarm changed the title (TF-18667) Enable component references (TF-18669) Enable component references Aug 15, 2024
@ansgarm ansgarm merged commit 8191b5e into pre-release Aug 15, 2024
5 checks passed
@ansgarm ansgarm deleted the enable_component_references branch August 15, 2024 08:58
jpogran added a commit that referenced this pull request Aug 30, 2024
This change enables the use of component references in the stack schema. This allows users to reference components in the same stack, and have the schema automatically update to reflect the available outputs of the referenced component.

Co-authored-by: Ansgar Mertens <[email protected]>
ansgarm added a commit that referenced this pull request Sep 23, 2024
This change enables the use of component references in the stack schema. This allows users to reference components in the same stack, and have the schema automatically update to reflect the available outputs of the referenced component.

Co-authored-by: Ansgar Mertens <[email protected]>
ansgarm added a commit that referenced this pull request Sep 23, 2024
This change enables the use of component references in the stack schema. This allows users to reference components in the same stack, and have the schema automatically update to reflect the available outputs of the referenced component.

Co-authored-by: Ansgar Mertens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants