-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(TF-18669) Enable component references #386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b49d08
to
13ee81c
Compare
13ee81c
to
cba9a8d
Compare
ansgarm
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Two comments / questions (I also pushed one commit that already addresses the one comment I had)
This change enables the use of component references in the stack schema. This allows users to reference components in the same stack, and have the schema automatically update to reflect the available outputs of the referenced component. Co-authored-by: Ansgar Mertens <[email protected]>
3a4707b
to
33c354e
Compare
ansgarm
approved these changes
Aug 15, 2024
jpogran
added a commit
that referenced
this pull request
Aug 30, 2024
This change enables the use of component references in the stack schema. This allows users to reference components in the same stack, and have the schema automatically update to reflect the available outputs of the referenced component. Co-authored-by: Ansgar Mertens <[email protected]>
ansgarm
added a commit
that referenced
this pull request
Sep 23, 2024
This change enables the use of component references in the stack schema. This allows users to reference components in the same stack, and have the schema automatically update to reflect the available outputs of the referenced component. Co-authored-by: Ansgar Mertens <[email protected]>
ansgarm
added a commit
that referenced
this pull request
Sep 23, 2024
This change enables the use of component references in the stack schema. This allows users to reference components in the same stack, and have the schema automatically update to reflect the available outputs of the referenced component. Co-authored-by: Ansgar Mertens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the use of component references in the stack schema. This allows users to reference components in the same stack, and have the schema automatically update to reflect the available outputs of the referenced component.
Needs hashicorp/hcl-lang#408