From da613b3947fbc84544109e86da752b05e5c54923 Mon Sep 17 00:00:00 2001 From: Alisdair McDiarmid Date: Wed, 1 Apr 2020 14:26:04 -0400 Subject: [PATCH] addrs: Fix diagnostic for invalid provider type This previously rendered as `Invalid provider type ""`, as `name` was empty if parsing failed. Using the source string is more helpful. --- addrs/provider.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addrs/provider.go b/addrs/provider.go index 01284300fd40..219e57725149 100644 --- a/addrs/provider.go +++ b/addrs/provider.go @@ -192,7 +192,7 @@ func ParseProviderSourceString(str string) (Provider, tfdiags.Diagnostics) { diags = diags.Append(&hcl.Diagnostic{ Severity: hcl.DiagError, Summary: "Invalid provider type", - Detail: fmt.Sprintf(`Invalid provider type %q in source %q: %s"`, name, str, err), + Detail: fmt.Sprintf(`Invalid provider type %q in source %q: %s"`, givenName, str, err), }) return ret, diags }