Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: fix url map test and update logic #12317

Merged
merged 1 commit into from
Mar 1, 2017

Conversation

danawillow
Copy link
Contributor

Happened to randomly stumble across this. The logic for checking if the "test" field change had two moments where it was looking at the wrong field, and the test that was checking the update function wasn't actually doing an update (it was just creating/destroying resources).

(Side note- is there a function or something in a test that can be used to make sure something was updated and not recreated?)

@stack72
Copy link
Contributor

stack72 commented Mar 1, 2017

LGTM nice catch @danawillow :)

@stack72 stack72 merged commit 75eb920 into hashicorp:master Mar 1, 2017
@stack72
Copy link
Contributor

stack72 commented Mar 1, 2017

@danawillow with regards to finding out if something is recreated - there is no built in function - I had to write one for DigitalOcean droplets

https://github.com/hashicorp/terraform/blob/master/builtin/providers/digitalocean/resource_digitalocean_droplet_test.go#L404

P.

@danawillow danawillow deleted the gce-url-map branch March 1, 2017 15:52
yanndegat pushed a commit to yanndegat/terraform that referenced this pull request Mar 13, 2017
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants