Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Force Deletion of Instances #12689

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

jtopjian
Copy link
Contributor

This commit adds the force_delete argument, enabling instances
to be forcefully deleted.

For #12674
Fixes #5104

/cc @cloudrkt

This commit adds the `force_delete` argument, enabling instances
to be forcefully deleted.
@stack72
Copy link
Contributor

stack72 commented Mar 14, 2017

Hey @jtopjian

Be aware that, if this resource supports import, then there will be a diff in the test as this value isn't set to state :)

P.

@jtopjian
Copy link
Contributor Author

@stack72 Ahh thanks. Instances aren't able to be imported yet (hopefully soon, though!)

What would be the best way to handle this in the future, though?

@stack72
Copy link
Contributor

stack72 commented Mar 14, 2017

if you look at the custom import function on aws_db_instance you can see how we set the defaults :)

@stack72 stack72 merged commit 9683f70 into hashicorp:master Mar 14, 2017
stack72 pushed a commit that referenced this pull request Mar 14, 2017
This commit adds the `force_delete` argument, enabling instances
to be forcefully deleted.
@jtopjian
Copy link
Contributor Author

Do you mean how the fields listed in import_aws_db_instance_test.go are ignored or the DiffSuppressFunc?

@stack72
Copy link
Contributor

stack72 commented Mar 14, 2017

Look at this

Importer: &schema.ResourceImporter{
			State: resourceAwsDbInstanceImport,
		},

@jtopjian
Copy link
Contributor Author

Ah - gotcha. Thank you! OK, that's really good to know. Might apply to some other areas, too. :)

@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openstack - Interesting things happen when soft delete is enabled
2 participants