provider/aws: Support ip_address_type for aws_alb #13227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack72
force-pushed
the
f-aws-alb-ip-address-type
branch
2 times, most recently
from
cd64e81 to
503f103
Compare
stack72
changed the title
radeksimko
reviewed
Apr 1, 2017
| } | ||
|
|
||
| stateConf := &resource.StateChangeConf{ | ||
| Pending: []string{"active", "provisioning", "failed"}, |
There was a problem hiding this comment.
I think this is a typo - active shouldn't be treated as Pending?
| @@ -71,6 +71,7 @@ func TestAccAWSALB_basic(t *testing.T) { | |||
| resource.TestCheckResourceAttrSet("aws_alb.alb_test", "zone_id"), | |||
| resource.TestCheckResourceAttrSet("aws_alb.alb_test", "dns_name"), | |||
| resource.TestCheckResourceAttrSet("aws_alb.alb_test", "arn"), | |||
| resource.TestCheckResourceAttrSet("aws_alb.alb_test", "ip_address_type"), | |||
There was a problem hiding this comment.
Any specific reason we can't check the value here and verify that it defaults to ipv4?
stack72
force-pushed
the
f-aws-alb-ip-address-type
branch
from
503f103 to
a5d6d96
Compare
Fixes: #11429 ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSALB_updatedIpAddressType' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/03/31 20:12:20 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSALB_updatedIpAddressType -timeout 120m === RUN TestAccAWSALB_updatedIpAddressType --- PASS: TestAccAWSALB_updatedIpAddressType (284.42s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 284.447s ```
stack72
force-pushed
the
f-aws-alb-ip-address-type
branch
from
a5d6d96 to
4c65678
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11429