-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAuth2 token support for GCS backend #21772
Conversation
3cf3f3e
to
ad25dcc
Compare
@paddycarver @emilymye @mildwonkey Anything I can do to speed up the review of this PR? |
@jbardin A quick and easy PR that would really unblock us with GCP remote states? |
ad25dcc
to
f6c90c1
Compare
This reverts commit 0aae628.
Thanks for this @luis-silva, it will help my team as well! According to the codeowners file, the @terraform-google group is the reviewer. |
Hm, apparently the group isn't set up 😕 |
Bump terraform version to 0.12.6
Hi folks! We cannot review this PR with a pending CLA signature. Please either sign the CLI, or remove the commit from @kostas-theo (see the CLA bot comment for details). |
@mildwonkey I've asked @kostas-theo to sign the CLA so we've both done it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we are already using that using a custom built here:
https://github.com/simonswine/terraform/releases/tag/v0.12.7-gcs-access-token
@mildwonkey Is this still waiting on review from someone? I would really like to see this merged. Having long-lived credentials stored on developer machines is a security risk that this feature would allow many people to avoid. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This PR aims to provide the functionality requested in issue #21680. The code was mostly inspired by what is already done in the GCP provider
I ran the following acceptance tests to validate correct operation:
TF_ACC=1 GOOGLE_OAUTH_ACCESS_TOKEN=XXXX GOOGLE_PROJECT=YYYY go test -timeout=2m -parallel=4 ./backend/remote-state/gcs ok github.com/hashicorp/terraform/backend/remote-state/gcs 36.882s