Consolidate repetitive warning messages #23425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our warning messages are produced in response to the use of deprecated language constructs that might be used many times across a whole configuration, and so the resulting warnings can easily overwhelm the other parts of Terraform's output from commands like
terraform plan
.As a compromise, we'll detect when the diagnostics includes more than two warnings with the same summary text and consolidate the third and any further warnings into a single count of additional warnings at the end of the second warning message, like this:
This is intended to strike a compromise between making sure these warnings remain visible but avoiding them distracting too much from other output that appears alongside them. This fixes #23406.