terraform: provider input should be scoped by path #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provider input before wasn't scoped by path, which caused non-descendant parts of the graph to grab the configuration of another sub-tree. The result is that you'd often get copied provider configurations across the module barriers. See GH-2024
|
LGTM, after having it explained to me synchronously. 😁 |
|
Yeah, good to merge this before I do the other provider bugs... since they might be related or already fixed by thyis. |
mitchellh
added a commit
that referenced
this pull request
Jun 24, 2015
terraform: provider input should be scoped by path
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2024
The provider input before wasn't scoped by path, which caused
non-descendant parts of the graph to grab the configuration of another
sub-tree. The result is that you'd often get copied provider
configurations across the module barriers.
This isn't very straightforward, but it was easy to reproduce with the example config in #2024 (changed to AWS for ease of config). I couldn't get a context test for this because of the weird parallelism, but added a test on the EvalContext which is important for this behavior.