Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: go get github.com/hashicorp/hcl/[email protected] #24650

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

alisdair
Copy link
Contributor

Upgrade to HCL v2.4.0, which includes a fix for a panic when parsing malformed JSON, and an upgrade to go-textseg for Unicode v12.0.

Fixes #23964, #22704.

@alisdair alisdair added the dependencies Auto-pinning label Apr 13, 2020
@alisdair alisdair requested a review from a team April 13, 2020 14:53
@alisdair alisdair self-assigned this Apr 13, 2020
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #24650 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
terraform/node_resource_plan.go 91.59% <0.00%> (-1.69%) ⬇️
dag/marshal.go 52.27% <0.00%> (-1.14%) ⬇️
terraform/evaluate.go 41.70% <0.00%> (-0.66%) ⬇️
states/statefile/version4.go 55.07% <0.00%> (-0.26%) ⬇️

Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alisdair alisdair merged commit 8e7ace4 into master Apr 14, 2020
@alisdair alisdair deleted the alisdair/upgrade-hcl branch April 14, 2020 13:21
@ghost
Copy link

ghost commented May 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing quote in json variables file make terraform crash
2 participants