Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vendor] upgrade go-cty #25078

Merged
merged 1 commit into from
May 29, 2020
Merged

[vendor] upgrade go-cty #25078

merged 1 commit into from
May 29, 2020

Conversation

pselle
Copy link
Contributor

@pselle pselle commented May 29, 2020

Upgrade go-cty to get jsonencode fix, closes #23062

$ go get -u github.com/zclconf/go-cty
$ go mod vendor
$ go mod tidy

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #25078 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
backend/remote/backend_common.go 54.57% <0.00%> (-0.68%) ⬇️
terraform/evaluate.go 53.15% <0.00%> (-0.46%) ⬇️
states/statefile/version4.go 56.16% <0.00%> (-0.29%) ⬇️
dag/marshal.go 53.40% <0.00%> (+1.13%) ⬆️

@pselle pselle requested a review from a team May 29, 2020 17:04
@pselle pselle changed the title [vendor] upgrate go-cty [vendor] upgrade go-cty May 29, 2020
go.sum Outdated
@@ -448,6 +448,8 @@ github.com/zclconf/go-cty v1.1.0/go.mod h1:xnAOWiHeOqg2nWS62VtQ7pbOu17FtxJNW8RLE
github.com/zclconf/go-cty v1.2.0/go.mod h1:hOPWgoHbaTUnI5k4D2ld+GRpFJSCe6bCM7m1q/N4PQ8=
github.com/zclconf/go-cty v1.4.1 h1:Xzr4m4utRDhHDifag1onwwUSq32HLoLBsp+w6tD0880=
github.com/zclconf/go-cty v1.4.1/go.mod h1:nHzOclRkoj++EU9ZjSrZvRG0BXIWt8c7loYc0qXAFGQ=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rerunning go mod tidy locally removed these 1.4.1 lines for me.

@pselle pselle force-pushed the pselle/jsonencode branch from eb31597 to 5e8b60b Compare May 29, 2020 19:32
@pselle pselle merged commit 195b59e into master May 29, 2020
@pselle pselle deleted the pselle/jsonencode branch June 1, 2020 20:14
@ghost
Copy link

ghost commented Jun 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsonencode - Invalid value for "val" parameter: argument must not be null.
2 participants