Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Convert block_device from TypeSet to TypeList #4288

Merged
merged 1 commit into from
Dec 17, 2015

Conversation

jtopjian
Copy link
Contributor

This change better reflects how block devices are passed to the Nova API
and allows for future enablement of block_device features. It also resolves
an interpolation bug.

Fixes #4090

This change better reflects how block devices are passed to the Nova API
and allows for future enablement of block_device features. It also resolves
an interpolation bug.
@jtopjian
Copy link
Contributor Author

I'm going to to go ahead and merge this one. Although I think the real cause of #4090 is a parsing bug in core, rather than fixing this issue by that route, I think changing block_device to TypeMap does three things:

  1. Inadvertently fixes the problem reported in openstack_compute_instance_v2.master: diffs didn't match during apply. This is a bug with Terraform and should be reported. #4090
  2. Better models how the block devices are submitted via the OpenStack API (See Adding multiple Ephemeral Volumes to Compute Instance on OpenStack #4042 as well as numerous references in the OpenStack code that ensure block_device_mapping_v2 is a list (Python array)).
  3. Enables features such as Adding multiple Ephemeral Volumes to Compute Instance on OpenStack #4042 to be enabled.

May I eat a hat if this blows up on me.

jtopjian added a commit that referenced this pull request Dec 17, 2015
provider/openstack: Convert block_device from TypeSet to TypeList
@jtopjian jtopjian merged commit 669ddbf into hashicorp:master Dec 17, 2015
@jtopjian jtopjian deleted the jtopjian-openstack-bfv-set2list branch March 23, 2017 16:07
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant