provider/vsphere: set uuid as vsphere_virtual_machine output

[eloycoto]

Hi,
Nowadays the vsphere resource only export the id, in this case is the vm_path/vm_name. So I added the option to get the vm uuid, that it's unique.

On the other hand, the connInfo set was not in place, so each time that you want to run remote-exec, you should add the host parameter. To be consistent with the other resources I added the first network address.

Regards.

[chrislovecnm]

@eloycoto need unit tests, and does this collide with #4978

cc: @phinze @jen20

[chrislovecnm]

@eloycoto ping ...

[stack72]

Hi @eloycoto / @chrislovecnm

Please can you let me know the status of this PR? It has been stale for a while now. I have marked it WIP. If there is still no movement, I will close at the end of June - we are trying to cut off the stale WIP PRs

thanks

Paul

[eloycoto]

Hey @stack72,

My fault, I'll make the changes this weekend. Sorry!

Regards.

[stack72]

@eloycoto you rock :)

[eloycoto]

Hey @stack72

Sorry for the delay. I had problems with govendor and I want to rebase the commits.

• I added uuid attribute in the virtual_machine resource, test and the doc.
• In other hand I delete the changes related with ConnInfo, it was fixed few weeks ago.

Should be ok now if not ping me and I'll fix it.
Regards.

[stack72]

Hi @eloycoto

The build failed I'm afraid

# github.com/hashicorp/terraform/builtin/providers/vsphere
builtin/providers/vsphere/resource_vsphere_virtual_machine_test.go:312: assignment count mismatch: 7 = 8
builtin/providers/vsphere/resource_vsphere_virtual_machine_test.go:356: assignment count mismatch: 7 = 8
builtin/providers/vsphere/resource_vsphere_virtual_machine_test.go:426: assignment count mismatch: 7 = 8
builtin/providers/vsphere/resource_vsphere_virtual_machine_test.go:514: assignment count mismatch: 7 = 8
builtin/providers/vsphere/resource_vsphere_virtual_machine_test.go:563: assignment count mismatch: 7 = 8
builtin/providers/vsphere/resource_vsphere_virtual_machine_test.go:778: assignment count mismatch: 7 = 8
builtin/providers/vsphere/resource_vsphere_virtual_machine_test.go:947: assignment count mismatch: 7 = 8

If you can sort this out, then this is good to merge :)

P.

[eloycoto]

Sorry! Now it's ok ;-)

[chrislovecnm]

@eloycoto can you put the full results of the unit tests in a gist? I would like to see that the tests are running locally.

Thanks

[stack72]

@chrislovecnm do you mean the unit tests or the acceptance tests? I don't think anyone (apart from you) will have a setup that can run them.

This is an addition of an output so I don't think it's crucial :)

[chrislovecnm]

@stack72 acceptance tests. Anyone that has an vsphere and esx servers can run them :) Some may fail, but we are getting them to the point where they will fail gracefully.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.