Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: Fix google_compute_backend_service max_utilization backend attribute #5075

Merged
merged 2 commits into from
Feb 12, 2016

Conversation

billf
Copy link
Contributor

@billf billf commented Feb 9, 2016

N.B. There is still no test coverage for this issue.

@billf billf changed the title Fix issue #4985 by correcting copy/paste error provider/google: Fix google_compute_backend_service max_utilization backend attribute Feb 9, 2016
Fixes issue hashicorp#4985 by correcting copy/paste error that caused the
max_utilization attribute to be read from the max_rate_per_instance
attribute.

N.B. There is still no test coverage for this issue.
@billf
Copy link
Contributor Author

billf commented Feb 12, 2016

i can rebase and force update if that's better than merge commits.

@jen20
Copy link
Contributor

jen20 commented Feb 12, 2016

Hi @billf! Thanks for this change - it clearly resolves a bug. For future reference, we ask that people don't edit the commit log in branches, and update it on merge. Thanks for the contribution!

jen20 added a commit that referenced this pull request Feb 12, 2016
provider/google: Fix google_compute_backend_service max_utilization backend attribute
@jen20 jen20 merged commit 636f05a into hashicorp:master Feb 12, 2016
@billf billf deleted the fix-issue-4895 branch February 13, 2016 03:04
terraformbot pushed a commit that referenced this pull request Feb 13, 2016
[origin/master] Merge pull request #5075 from uber/fix-issue-4895
636f05a
terraformbot pushed a commit that referenced this pull request Feb 13, 2016
[origin/master] Merge pull request #5075 from uber/fix-issue-4895
636f05a
terraformbot pushed a commit that referenced this pull request Feb 13, 2016
[origin/master] Merge pull request #5075 from uber/fix-issue-4895
636f05a
terraformbot pushed a commit that referenced this pull request Feb 13, 2016
[origin/master] Merge pull request #5075 from uber/fix-issue-4895
636f05a
terraformbot pushed a commit that referenced this pull request Feb 13, 2016
[origin/master] Merge pull request #5075 from uber/fix-issue-4895
636f05a
terraformbot pushed a commit that referenced this pull request Feb 13, 2016
[origin/master] Merge pull request #5075 from uber/fix-issue-4895
636f05a
terraformbot pushed a commit that referenced this pull request Feb 13, 2016
[origin/master] Merge pull request #5075 from uber/fix-issue-4895
636f05a
terraformbot pushed a commit that referenced this pull request Feb 13, 2016
[origin/master] Merge pull request #5075 from uber/fix-issue-4895
636f05a
terraformbot pushed a commit that referenced this pull request Feb 13, 2016
[origin/master] Merge pull request #5075 from uber/fix-issue-4895
636f05a
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants