Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws : Opsworks fails on update #6077

Closed
u2mejc opened this issue Apr 8, 2016 · 3 comments · Fixed by #6078
Closed

provider/aws : Opsworks fails on update #6077

u2mejc opened this issue Apr 8, 2016 · 3 comments · Fixed by #6078
Labels
bug provider/aws waiting-response An issue/pull request is waiting for a response from the community

Comments

@u2mejc
Copy link
Contributor

u2mejc commented Apr 8, 2016

Opsworks fails during updates:

Error applying plan:

1 error(s) occurred:

* aws_opsworks_stack.main: ValidationException: Custom Cookbooks Source's Type: Unsupported scm type
        status code: 400, request id: *snip*

This is due to the provider "computing" empty fields and adding it to the JSON request:

2016/04/07 19:17:06 [DEBUG] terraform-provider-aws:   CustomCookbooksSource: {
2016/04/07 19:17:06 [DEBUG] terraform-provider-aws:     Password: "",
2016/04/07 19:17:06 [DEBUG] terraform-provider-aws:     Revision: "",
2016/04/07 19:17:06 [DEBUG] terraform-provider-aws:     SshKey: "",
2016/04/07 19:17:06 [DEBUG] terraform-provider-aws:     Type: "",
2016/04/07 19:17:06 [DEBUG] terraform-provider-aws:     Url: "",
2016/04/07 19:17:06 [DEBUG] terraform-provider-aws:     Username: ""
2016/04/07 19:17:06 [DEBUG] terraform-provider-aws:   },
@catsby
Copy link
Contributor

catsby commented Apr 8, 2016

Hey @u2mejc – do you have a simple config that demonstrates this problem? The computed flag tells Terraform that the API may return data and to not worry about it; the resource itself is not populating empty data on it's own. Or, it shouldn't 😄

I did some debugging, and found that the CustomCookbooksSource source that's returned from DescribeStacks call here is coming back empty, instead of the typical nil. As a result we're storing empty values when we should omit it if nothing there is found. Do you think you could adjust #6078 to account for that?

@catsby catsby added the waiting-response An issue/pull request is waiting for a response from the community label Apr 8, 2016
@u2mejc
Copy link
Contributor Author

u2mejc commented Apr 12, 2016

Please see comments in PR: #6078

@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants