Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/azurerm: Add support for storage container name validation #6852

Merged
merged 1 commit into from
May 24, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented May 24, 2016

Fixes #6846

make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestValidateArmStorageContainerName'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestValidateArmStorageContainerName -timeout 120m
=== RUN   TestValidateArmStorageContainerName
--- PASS: TestValidateArmStorageContainerName (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm        0.012s

@@ -7,6 +7,7 @@ import (

"github.com/Azure/azure-sdk-for-go/storage"
"github.com/hashicorp/terraform/helper/schema"
"regexp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs running through goimports

@jen20
Copy link
Contributor

jen20 commented May 24, 2016

Left two comments in line but other than that LGTM!

@stack72 stack72 force-pushed the f-arm-storagecont-validation branch from 70410f6 to 21cc68a Compare May 24, 2016 21:12
@stack72
Copy link
Contributor Author

stack72 commented May 24, 2016

@jen20 made the 2 small changes you asked for - will merge when (if?) Travis goes green :)

@stack72 stack72 merged commit d997b3f into master May 24, 2016
@stack72 stack72 deleted the f-arm-storagecont-validation branch May 24, 2016 21:30
@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for invalid characters within azurerm_storage_container
2 participants