AWS Spot fleet resource

[keshavdv]

This adds a Spot fleet resource to AWS, docs and some acceptance tests. We've been using this for a bit in our own environment without any issues.

Fixes #4070

[jen20]

Hi @keshavdv! Thanks for opening a pull request. I've taken a quick look over it and it looks good to me - one request however: could you rebase this onto master and squash it into a single commit? Thanks!

[keshavdv]

Done! Fixes #4070

[solarkennedy]

^ keep in mind that "fixes" thing has to be in the "body" of the PR to work (otherwise it is just a reference, not an auto-close thing):
https://github.com/blog/1506-closing-issues-via-pull-requests

[keshavdv]

Huh, didn't know that. Updated the PR.

[stack72]

Thanks for rebasing this PR @keshavdv

On running the tests, I could see they were targetted towards us-east-1, but no region was added to the region:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
2016/06/23 07:55:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_ -timeout 120m
=== RUN   TestAccAWSSpotFleetRequest_basic
--- FAIL: TestAccAWSSpotFleetRequest_basic (73.70s)
    testing.go:255: Step 0 error: Error applying: 1 error(s) occurred:

        * aws_spot_fleet_request.foo: Error requesting spot fleet: [WARN] Error creating Spot fleet request, retrying: InvalidSpotFleetRequestConfig: Invalid Amazon Machine Image(s) specified: The image id '[ami-f652979b]' does not exist (Service: AmazonEC2; Status Code: 400; Error Code: InvalidAMIID.NotFound; Request ID: bfd448e2-0979-4ed1-bd30-fba3f47c3b1a).
            status code: 400, request id: f7d44743-6108-4de8-aef7-a5432b604a8c
=== RUN   TestAccAWSSpotFleetRequest_launchConfiguration
--- FAIL: TestAccAWSSpotFleetRequest_launchConfiguration (14.84s)
    testing.go:255: Step 0 error: Error applying: 1 error(s) occurred:

        * aws_spot_fleet_request.foo: InvalidAMIID.NotFound: The image id '[ami-f652979b]' does not exist
            status code: 400, request id: ed45e060-06b5-4250-8caf-ceebddf23b16
=== RUN   TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName
--- PASS: TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName (0.00s)
FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/aws    88.553s

I then changed the tests to use us-west-2a and ami-d06a90b0 (and m1.small to keep the testing costs down) for us-west and got the following results:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
2016/06/23 08:11:21 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_ -timeout 120m
=== RUN   TestAccAWSSpotFleetRequest_basic
--- PASS: TestAccAWSSpotFleetRequest_basic (29.91s)
=== RUN   TestAccAWSSpotFleetRequest_launchConfiguration
--- PASS: TestAccAWSSpotFleetRequest_launchConfiguration (31.60s)
=== RUN   TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName
--- PASS: TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    61.523s

I have manually merged this with these changes (ef0302e) :)

Thanks for the work here

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.