aws: Adding in additional retry logic due to latency with delete of db_option_group

[jrnt30]

Fixes #7311

[jen20]

Hi @jrnt30! Thanks for opening a pull request - it looks good to me. However, are we sure that a 1 minute retry window is sufficient here?

[jen20]

In light of the issue and the passing acceptance test I'll merge this now and we can increase the time out in future if necessary.

[jrnt30]

That is a fair point. It seems in general the timeouts are somewhat conservative on a few other resources as well but it would probably be more robust to simply increase it.

I'll monitor it over the next few days

[catsby]

Hey Friends –

This looks good to me. I ran the tests as well:

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBOptionGroup -timeout 120m
=== RUN   TestAccAWSDBOptionGroup_basic
--- PASS: TestAccAWSDBOptionGroup_basic (19.33s)
=== RUN   TestAccAWSDBOptionGroup_basicDestroyWithInstance
--- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (551.74s)
=== RUN   TestAccAWSDBOptionGroup_OptionSettings
--- PASS: TestAccAWSDBOptionGroup_OptionSettings (38.34s)
=== RUN   TestAccAWSDBOptionGroup_sqlServerOptionsUpdate
--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (38.27s)
=== RUN   TestAccAWSDBOptionGroup_multipleOptions
--- PASS: TestAccAWSDBOptionGroup_multipleOptions (19.61s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    667.299s
Test:

Fwiw I've not seen this error, and we do have an existing DB Instance test that uses a db option group and I've not seen it, so I'm fine with just a 1 minute retry.

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.