provider/aws: Validate aws_iam_policy_attachment Name parameter to stop being empty
#8441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stop being empty Fixes #8368 ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSPolicyAttachment_' ==> Checking that code complies with gofmt requirements... /Users/stacko/Code/go/bin/stringer go generate $(go list ./... | grep -v /terraform/vendor/) 2016/08/24 11:46:01 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSPolicyAttachment_ -timeout 120m === RUN TestAccAWSPolicyAttachment_basic --- PASS: TestAccAWSPolicyAttachment_basic (44.67s) === RUN TestAccAWSPolicyAttachment_paginatedEntities --- PASS: TestAccAWSPolicyAttachment_paginatedEntities (161.68s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 206.379s ```
| @@ -25,6 +25,14 @@ func resourceAwsIamPolicyAttachment() *schema.Resource { | |||
| Type: schema.TypeString, | |||
| Required: true, | |||
| ForceNew: true, | |||
| ValidateFunc: func(v interface{}, k string) (ws []string, errors []error) { | |||
| value := v.(string) | |||
| if value == "" { | |||
There was a problem hiding this comment.
nitpick if you want, you can just do if v.(string) == ""
|
LGTM! One nitpick but otherwise good to go. |
richardbowden
pushed a commit
to richardbowden/terraform
that referenced
this pull request
Aug 27, 2016
…stop being empty (hashicorp#8441) * provider/aws: Validate `aws_iam_policy_attachment` Name parameter to stop being empty Fixes hashicorp#8368 ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSPolicyAttachment_' ==> Checking that code complies with gofmt requirements... /Users/stacko/Code/go/bin/stringer go generate $(go list ./... | grep -v /terraform/vendor/) 2016/08/24 11:46:01 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSPolicyAttachment_ -timeout 120m === RUN TestAccAWSPolicyAttachment_basic --- PASS: TestAccAWSPolicyAttachment_basic (44.67s) === RUN TestAccAWSPolicyAttachment_paginatedEntities --- PASS: TestAccAWSPolicyAttachment_paginatedEntities (161.68s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 206.379s ``` * Update resource_aws_iam_policy_attachment.go
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8368